-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update public docs for device trust web #41334
Conversation
Separate commits for easier reviewing, although this ended up being quite small. I'm running the docs dev server locally, so it should render into something sensible. I was torn about having a section that shows the web login, but decided against it as (I would hope!) it's easy and intuitive enough to get working. Plus, I didn't want to capture a screenshot that could quickly get outdated. |
🤖 Vercel preview here: https://docs-o5xhz23z0-goteleport.vercel.app/docs/ver/preview |
🤖 Vercel preview here: https://docs-aj7dahwte-goteleport.vercel.app/docs/ver/preview |
docs/pages/access-controls/device-trust/enforcing-device-trust.mdx
Outdated
Show resolved
Hide resolved
Desktop access may enforce device trust via [role-based enforcement]( | ||
#role-based-trusted-device-enforcement). | ||
|
||
To access desktops protected by device trust make sure your device is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we capitalizing "device trust"? I would use consistent capitalization so readers know whether to treat this is as a Teleport-specific feature—if it's a general computing term that's not unique to Teleport, it would make sense to use lowercase everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a look and see what we are doing. Do you have a preference for capitalized or not in this particular case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. It's a mixed bag for sure, we use both capitalized and not in various places. If you have a suggestion, @ptgott, I'd be happy to write a follow-up "normalizing" it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The AWS Verified Access docs say "device trust", although Okta capitalizes "Device Trust". I think this is a general enough computing term that "device trust" makes sense, though to be honest I can see "Device Trust" making sense as well. I'll ask Marketing and write a Vale rule for it so we can decouple the standardization work from this PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great, thanks!
🤖 Vercel preview here: https://docs-3q3h820zv-goteleport.vercel.app/docs/ver/preview |
Update Device Trust pages in preparation for device trust web:
https://github.com/gravitational/teleport.e/issues/3236