Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignores resizes when a desktop has screen_size set #41198

Merged
merged 2 commits into from
May 6, 2024

Conversation

ibeckermayer
Copy link
Contributor

@ibeckermayer ibeckermayer commented May 4, 2024

screen_size is meant to be a static override of the screen size, however this property was mistakenly lost when
#39819 was merged.

This commit restores the behavior of screen_size by ignoring resizes when it is set.

changelog: Fixes screen_size behavior.

`screen_size` is meant to be a static override of the screen size,
however this property was mistakenly lost when
#39819 was merged.

This commit restores the behavior of `screen_size` by ignoring resizes
when it is set.
Copy link

github-actions bot commented May 4, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions github-actions bot requested review from avatus and rudream May 4, 2024 03:04
lib/srv/desktop/rdp/rdpclient/client_common.go Outdated Show resolved Hide resolved
@ibeckermayer ibeckermayer added this pull request to the merge queue May 6, 2024
Merged via the queue into master with commit b416859 May 6, 2024
43 checks passed
@ibeckermayer ibeckermayer deleted the isaiah/fix-screen-size branch May 6, 2024 20:52
@public-teleport-github-review-bot

@ibeckermayer See the table below for backport results.

Branch Result
branch/v15 Failed

ibeckermayer pushed a commit that referenced this pull request May 6, 2024
* Ignores resizes when a desktop has `screen_size` set

`screen_size` is meant to be a static override of the screen size,
however this property was mistakenly lost when
#39819 was merged.

This commit restores the behavior of `screen_size` by ignoring resizes
when it is set.

* hasSizeOverride and //nolint
github-merge-queue bot pushed a commit that referenced this pull request May 6, 2024
* Ignores resizes when a desktop has `screen_size` set

`screen_size` is meant to be a static override of the screen size,
however this property was mistakenly lost when
#39819 was merged.

This commit restores the behavior of `screen_size` by ignoring resizes
when it is set.

* hasSizeOverride and //nolint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants