[v13] always require MFA when joining a session if at least one role requires session MFA #39816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es session MFA * extend role 'join_sessions' so MFA can be required at the role level when joining sessions * add test cases * update operator CRDs * remove change to 'join_sessions', instead require MFA if any roles require it * add comment * address feedback * add additional test cases * add authhandler test * fix role from test case not getting used in test
capnspacehook
commented
Mar 26, 2024
codingllama
approved these changes
Mar 26, 2024
rosstimothy
approved these changes
Mar 26, 2024
tcsc
added a commit
that referenced
this pull request
Mar 27, 2024
* Fixed possible phishing links which could result in code execution with install and join scripts. [#39839](#39839) * Fixed MFA checks not being prompted when joining a session. [#39816](#39816) * Fixed broken SSO login landing page on certain versions of Google Chrome. [#39721](#39721) * Updated Electron to v29 in Teleport Connect. [#39659](#39659) * Fixed a bug in the discovery script failing when `jq` was not installed. [#39601](#39601)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
* Fixed possible phishing links which could result in code execution with install and join scripts. [#39839](#39839) * Fixed MFA checks not being prompted when joining a session. [#39816](#39816) * Fixed broken SSO login landing page on certain versions of Google Chrome. [#39721](#39721) * Updated Electron to v29 in Teleport Connect. [#39659](#39659) * Fixed a bug in the discovery script failing when `jq` was not installed. [#39601](#39601)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #39602.
Note that the unit test had to be reworked a bit to call IsMFARequired instead of CreateAuthenticateChallenge, because in v13 CreateAuthenticateChallengeRequest doesn't have a MFARequiredCheck field.
changelog: fix MFA checks not being prompted when joining a session