Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: jq has been missing in the installer scripts #39529

Conversation

tunguyen9889
Copy link
Contributor

@tunguyen9889 tunguyen9889 commented Mar 18, 2024

The installer script which was updated in #39033 has 2 issues:

  • Missing jq package in the no automatic upgrades condition.
  • Forgot to remove sudo zypper --non-interactive install ${PACKAGE_LIST} line when removed the $PACKAGE_LIST var.

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot requested review from jimbishopp and r0mant March 18, 2024 19:57
@tunguyen9889 tunguyen9889 changed the title jq has been missing in the installer scripts Fix: jq has been missing in the installer scripts Mar 18, 2024
@zmb3 zmb3 requested a review from hugoShaka March 18, 2024 21:16
@tunguyen9889
Copy link
Contributor Author

Thanks @hugoShaka and @tigrato for approving this! But I'm not sure if it needs approval from maintainers before merging, as the workflow failed with code:

2024/03/19 18:38:10 Workflow check failed: at least two approvals required from [jimbishopp klizhentas r0mant russjones zmb3].

@hugoShaka
Copy link
Contributor

Hi @tunguyen9889,

Thanks for your contribution. We are currently unable to run our tests on
external contributions. As such, I'll be helping you validate and
merge your pull request. I've created an internal PR here:

Please and I'll get your code merged. You will retain authorship of your commits.

@hugoShaka hugoShaka closed this Mar 19, 2024
@tunguyen9889 tunguyen9889 deleted the feature/missing-jq-in-installer branch March 20, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants