-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements ResourceWithLabels on AccessListMember #39498
Conversation
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
api/types/accesslist/member.go
Outdated
var _ types.ResourceWithOrigin = (*AccessListMember)(nil) | ||
var _ types.ResourceWithLabels = (*AccessListMember)(nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var _ types.ResourceWithOrigin = (*AccessListMember)(nil) | |
var _ types.ResourceWithLabels = (*AccessListMember)(nil) | |
var ( | |
_ types.ResourceWithOrigin = (*AccessListMember)(nil) | |
_ types.ResourceWithLabels = (*AccessListMember)(nil) | |
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The appearance of the blank identifier in this construct indicates that the declaration exists only for the type checking, not to create a variable. Don't do this for every type that satisfies an interface, though. By convention, such declarations are only used when there are no static conversions already present in the code, which is a rare event.
https://golang.google.cn/doc/effective_go#interfaces_and_types
Do any static conversion already exist? If there aren't and this is to remain, types. ResourceWithOrigin
is embedded in types.ResourceWithLabels
so I think we can likely reduce this to a single var _ types.ResourceWithLabels = (*AccessListMember)(nil)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted.
@mdwn do access list members have labels, generally speaking? |
They do now that Okta access list sync is a thing. |
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
No description provided.