Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wasm-pack builds #37851

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Fix wasm-pack builds #37851

merged 2 commits into from
Feb 7, 2024

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Feb 7, 2024

No description provided.

@github-actions github-actions bot requested review from rudream and ryanclark February 7, 2024 15:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@codingllama codingllama mentioned this pull request Feb 7, 2024
Merged
zmb3 added 2 commits February 7, 2024 11:01
@zmb3
Add wasm32-unknown-unknown target to docker images
75b2565 
wasm-pack will do this at build time if the target is not available,
but by baking it into the image we avoid having to do it during each
build.
@zmb3
Update wasm-bindgen to 0.2.91
6d960ed 
And make sure that we always install the version from the lockfile,
which prevents wasm-pack from failing with --mode=no-install.
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@zmb3 zmb3 added the no-changelog Indicates that a PR does not require a changelog entry label Feb 7, 2024
@codingllama
Copy link
Contributor

@zmb3, I think you'll need to pin golangci-lint to v1.55.2 here: https://github.com/gravitational/teleport.e/blob/b20f3215c07757428e1a43acd1268afe54992877/.github/workflows/lint.yaml#L40.

I can update it again after CI stabilizes.

@codingllama
Copy link
Contributor

@zmb3, I think you'll need to pin golangci-lint to v1.55.2 here: https://github.com/gravitational/teleport.e/blob/b20f3215c07757428e1a43acd1268afe54992877/.github/workflows/lint.yaml#L40.

I can update it again after CI stabilizes.

Sorry, this comment was meant for https://github.com/gravitational/teleport.e/pull/3382. I see you fixed it already.

@zmb3 zmb3 added this pull request to the merge queue Feb 7, 2024
Merged via the queue into master with commit 663c1a7 Feb 7, 2024
40 of 41 checks passed
@zmb3 zmb3 deleted the zmb3/wasm-fixes branch February 7, 2024 19:24
@public-teleport-github-review-bot
Copy link

@zmb3 See the table below for backport results.

Branch Result
branch/v13 Failed
branch/v14 Failed
branch/v15 Create PR

@zmb3 zmb3 mentioned this pull request Feb 7, 2024
Merged
zmb3 added a commit that referenced this pull request Feb 7, 2024
@zmb3
build: add --locked flag to cargo build
196876e 
Partial backport of #37851
@zmb3 zmb3 mentioned this pull request Feb 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 7, 2024
@zmb3
build: add --locked flag to cargo build (#37858)
0a09ae3 
Partial backport of #37851
github-actions bot pushed a commit that referenced this pull request Feb 7, 2024
@zmb3
build: add --locked flag to cargo build
c9701f1 
Partial backport of #37851
@zmb3 zmb3 mentioned this pull request Feb 13, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosstimothy rosstimothy rosstimothy approved these changes

@codingllama codingllama codingllama approved these changes

Assignees
No one assigned
Labels
backport/branch/v15 no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmb3 @codingllama @rosstimothy