Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Automatic Cloud Passwordless preference setting to the Auth service #35807

Merged
merged 7 commits into from
Dec 21, 2023

Conversation

Joerger
Copy link
Contributor

@Joerger Joerger commented Dec 16, 2023

Automatically set passwordless connector from the Auth service instead of the Proxy service. This prevents an additional few roundtrips to the Auth server, some of which would require MFA for admin actions (SetClusterAuthPreference).

Unblocks #35542

Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@Joerger Joerger added the no-changelog Indicates that a PR does not require a changelog entry label Dec 16, 2023
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from lxea December 19, 2023 20:15
@Joerger Joerger enabled auto-merge December 19, 2023 20:17
@Joerger
Copy link
Contributor Author

Joerger commented Dec 21, 2023

@r0mant @zmb3 Can I get a flaky test skip? The affected test takes 8 which is unchanged.

@r0mant
Copy link
Collaborator

r0mant commented Dec 21, 2023

/excludeflake *

@Joerger Joerger added this pull request to the merge queue Dec 21, 2023
Merged via the queue into master with commit 5925f79 Dec 21, 2023
33 checks passed
@Joerger Joerger deleted the joerger/set-passwordless-connector-from-auth branch December 21, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants