MFA for Admin Actions: roles #35445
Merged
MFA for Admin Actions: roles #35445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Joerger
added
the
no-changelog
Joerger
force-pushed
the
joerger/admin-actions-roles
branch
2 times, most recently
from
1492e91 to
bcc8638
Compare
Joerger
force-pushed
the
joerger/admin-actions-users
branch
from
7e6e922 to
9c67912
Compare
Joerger
force-pushed
the
joerger/admin-actions-roles
branch
from
bcc8638 to
e755932
Compare
Joerger
force-pushed
the
joerger/admin-actions-users
branch
from
9c67912 to
d59bb0f
Compare
Joerger
force-pushed
the
joerger/admin-actions-roles
branch
2 times, most recently
from
82f5e88 to
3b0a4e2
Compare
|
When trying to update a role I got the following errors:
Here's my user configuration I would expect a request for OTP but didn't had one, at least one that I could actually use. Did I do something wrong? Or it's just not working as expected? |
Joerger
force-pushed
the
joerger/admin-actions-users
branch
from
d59bb0f to
b9a1850
Compare
|
@marcoandredinis It's expected that OTP wouldn't work on the WebUI. This is something I hope to add after the initial v15 release if it can be prioritized. It should work with Edit: fixed otp prompt in #35537 |
Joerger
force-pushed
the
joerger/admin-actions-users
branch
from
b9a1850 to
d7b206d
Compare
Joerger
force-pushed
the
joerger/admin-actions-roles
branch
from
3b0a4e2 to
92e7e84
Compare
Joerger
force-pushed
the
joerger/admin-actions-roles
branch
from
92e7e84 to
f23af78
Compare
ravicious
approved these changes
Dec 8, 2023
marcoandredinis
approved these changes
Dec 11, 2023
Joerger
force-pushed
the
joerger/admin-actions-users
branch
2 times, most recently
from
16de23f to
8bccc53
Compare
Joerger
force-pushed
the
joerger/admin-actions-roles
branch
2 times, most recently
from
bb28377 to
098c2a7
Compare
This was referenced Dec 12, 2023
Joerger
force-pushed
the
joerger/admin-actions-roles
branch
from
098c2a7 to
acb9820
Compare
Joerger
force-pushed
the
joerger/admin-actions-users
branch
from
3884f1f to
9ca0d37
Compare
Joerger
force-pushed
the
joerger/admin-actions-roles
branch
from
acb9820 to
a924514
Compare
Joerger
force-pushed
the
joerger/admin-actions-roles
branch
from
a924514 to
49f969f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require MFA for role CRUD.
Part of RFD 131.
Based off #35386 to use the same test helpers.