[Assist] Do not parse event data is there is none #27431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is no session data UI should not try to parse them, otherwise it will crash as this happens currently.
r0mant
approved these changes
Jun 5, 2023
jakule
force-pushed
the
jakule/missing-event-assist-crash
branch
from
6b97d10
to
d77a1bd
Compare
kimlisa
approved these changes
Jun 5, 2023
Co-authored-by: Lisa Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no session data UI should not try to parse them. Otherwise, it will crash as this happens currently.
Example:
