Update missing color in Connect, reorder More Options menu items #24593
Conversation
| { | ||
| title: 'Open new terminal', | ||
| isVisible: isSearchBarEnabled, | ||
| Icon: icons.Terminal, | ||
| keyboardShortcutAction: 'newTerminalTab', | ||
| onNavigate: openTerminalTab, | ||
| }, |
There was a problem hiding this comment.
What do you think about adding a separator between 'Open new terminal' and 'Open config file'?
It seems to me that 'Open config file', 'Install tsh in PATH' and 'Remove tsh from PATH' can be considered as a logical group.
There was a problem hiding this comment.
I'm not sure about it, how does opening a config file relate to installing tsh in PATH? If anything, opening a new terminal could be grouped with the two tsh items. But then we'd also have to make the separator not show up on platforms other than macOS since they don't have those extra tsh items.
There was a problem hiding this comment.
how does opening a config file relate to installing tsh in PATH?
I think about it as config-related stuff, 'Open config file' configures Connect, installing tsh in PATH configures your OS. But it is just an idea, I'm fine with merging it as is.
The "Open new terminal" item was introduced in the search bar PR, before the theme got updated in #23539. When rebasing the original search bar PR on top of theme changes, I forgot to update colors outside of the search bar directory.
Additionally, this PR moves "Open new terminal" to the top of the list because it's likely to be used more often than opening the config file.