Connect: Prepare fonts configuration #22176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we used words like: "key", "type", "shortcut" which were really confusing (and I wrote this code), because it was hard to tell what exactly they describe. From now, we will use only "accelerator" (borrowed from Electron) and "action" words. For example, in a shortcut "Command+1": "tab-1": - "Command+1" is "accelerator" - "tab-1" is "action"
With "-" we are not able to use this symbol as a valid key code.
|
You mean shortcuts configuration? :D |
|
Sorry, I will reopen the PRs 🤦♂️🤦♂️🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/2
Part of #21914
Initially I wanted to create a single PR for all the changes, but I realized that it will be hard to review. The PR that actually enables fonts configuration is here.
In this PR I focused on renaming a few things:
Command+1) and "action" (e.g.tab1) words. Previously, we used words like: "key", "type", "shortcut" which were really confusing (even for me who wrote this code 🙃). I borrowed "accelerator" from Electron.keymap.tabNew, tokeymap.newTabto make them all more consistent.keymap.toggleClusterstokeymap.openClusters. "Toggle" sounds like a more serious and permanent action, while it only opens (and closes) a popup.tab-1totab1to match config keys (keymap.tab1).I also changed the separator for the accelerators. With "-" we were not able to use this symbol as a valid key code.
Best to review commit by commit.