Fix resource access requests for apps #13955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tsh
ravicious
reviewed
Jun 29, 2022
ravicious
approved these changes
Jun 30, 2022
jakule
approved these changes
Jun 30, 2022
lib/services/access_request.go
Outdated
|
|
||
| // namesMatcher returns a PredicateExpression which matches any of a given list | ||
| // of names. Given names will be escaped and quoted when building the expression. | ||
| func namesMatcher(names []string) string { |
There was a problem hiding this comment.
nit: I'd change the name to namesOrMatcher to indicate that the final expression uses the || operator. Feel free to leave as it is if you think that the comment is enough.
There was a problem hiding this comment.
I went with anyNameMatcher so it doesn't sound like it might return some names OR a matcher 🤷♂️
|
@nklaassen See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource access requests for apps are currently broken for static apps because I incorrectly assumed they would be returned from calls to
GetApp, which is not the case.The change here is to use
ListResourcesinstead ofGetApp,GetNode, etc... inPruneResourceRequestRoles. This is more consistent with the way we search for resources and build the access request in the first place withtsh request searchand from the web UI, whereListResourcesis already used.