Favor newer Touch ID credentials within the allowed set #13672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
added
the
test-plan-problem
strideynet
approved these changes
Jun 21, 2022
ravicious
approved these changes
Jun 21, 2022
|
Thanks for the quick review, folks. |
codingllama
force-pushed
the
codingllama/touchid-regressions
branch
from
89e9894 to
bbf3ef6
Compare
codingllama
force-pushed
the
codingllama/touchid-regressions
branch
from
bbf3ef6 to
162abec
Compare
codingllama
force-pushed
the
codingllama/touchid-regressions
branch
from
162abec to
2981913
Compare
codingllama
added a commit
that referenced
this pull request
Jun 21, 2022
Favor newer Touch ID credentials in the allowed set for MFA, or just the newer credential for passwordless. Fixes a capture-by-reference bug and adds coverage for it. Issue #13340. * Add tests for Touch ID credential-choosing logic * Favor newer Touch ID credentials within the allowed set * Warn about origin vs RPID mismatch
codingllama
added a commit
that referenced
this pull request
Jun 22, 2022
Favor newer Touch ID credentials in the allowed set for MFA, or just the newer credential for passwordless. Fixes a capture-by-reference bug and adds coverage for it. Issue #13340. * Add tests for Touch ID credential-choosing logic * Favor newer Touch ID credentials within the allowed set * Warn about origin vs RPID mismatch
codingllama
added a commit
that referenced
this pull request
Jun 22, 2022
#13712) Favor newer Touch ID credentials in the allowed set for MFA, or just the newer credential for passwordless. Fixes a capture-by-reference bug and adds coverage for it. Issue #13340. Backports #13672 and #13761. * Add tests for Touch ID credential-choosing logic * Favor newer Touch ID credentials within the allowed set * Warn about origin vs RPID mismatch * Do not dereference assertion before checking for nil
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Favor newer Touch ID credentials in the allowed set for MFA, or just the newer credential for passwordless.
Fixes a capture-by-reference bug and adds coverage for it.
Issue #13340.