Refactoring of architecture section. #13651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klizhentas
force-pushed
the
sasha/architecture
branch
from
c139640 to
b3a8ce0
Compare
zmb3
reviewed
Jun 18, 2022
webvictim
reviewed
Jun 20, 2022
| @@ -1,53 +1,60 @@ | |||
| --- | |||
There was a problem hiding this comment.
As a general comment, we ought to add a page similar to this which explains exactly what a Teleport Agent is, what it does and when you should use it. At the moment it's easy to see what the architecture of ssh_service is, but it's less clear for any of the other protocols we support.
There was a problem hiding this comment.
yes, good idea, but we don't have specifically have Teleport agent as a term. We have proxy service that has multiple knobs and ssh service. We need to think how to structure it all better though.
klizhentas
force-pushed
the
sasha/architecture
branch
from
6d93363 to
874d9ca
Compare
klizhentas
force-pushed
the
sasha/architecture
branch
from
874d9ca to
2bf17bd
Compare
zmb3
approved these changes
Jun 23, 2022
r0mant
approved these changes
Jun 23, 2022
klizhentas
force-pushed
the
sasha/architecture
branch
3 times, most recently
from
6525664 to
886debb
Compare
Our architecture section was written almost 5 years ago and was completely obsolete. I refactored all of it to be up to date, added Kuberentes and other resource type references, replaced and created new diagrams.
klizhentas
force-pushed
the
sasha/architecture
branch
from
886debb to
2815588
Compare
klizhentas
added a commit
that referenced
this pull request
Jun 23, 2022
Our architecture section was written almost 5 years ago and was completely obsolete. I refactored all of it to be up to date, added Kuberentes and other resource type references, replaced and created new diagrams.
klizhentas
added a commit
that referenced
this pull request
Jun 23, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our architecture section was written almost 5 years ago
and was obsolete.
I refactored all of it to be up to date, added Kuberentes
and other resource type references, replaced and created new diagrams.