Fix database role fetch for tsh db ls --all
#13617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tsh
rosstimothy
reviewed
Jun 17, 2022
There was a problem hiding this comment.
Can we extract the role set fetching into a common function that listDatabasesAllClusters and onListDatabases both call? That would help ensure that we don't deviate again in the future and would also allow others that need to do this to not fall into the same trap.
rosstimothy
approved these changes
Jun 17, 2022
|
I think v9 is also affected, hence adding the backport-v9 label. |
Tener
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
Confirmed to work now:
$ tsh db ls --all
Proxy Cluster Name Description Allowed Users Labels Connect
------------------- -------------- ----------------------- ------------------- ------------------------- ---------------- ------------------------------
boson.tener.io:3080 boson.tener.io > mymongo (user: alice) [alice bob tener] env=dev tsh db connect --db-name=<n...
boson.tener.io:3080 boson.tener.io mymongo-insecure [alice bob tener] env=dev
boson.tener.io:3080 boson.tener.io redisboson Boson Redis example [alice bob tener] env=dev
boson.tener.io:3080 quark.tener.io qmongo [* alice bob quark tener] cl=quark
boson.tener.io:3080 quark.tener.io qmongo-insecure [* alice bob quark tener] cl=quark
boson.tener.io:3080 quark.tener.io redisquark Quark Redis example [* alice bob quark tener] cl=quark,env=dev
Thanks for the quick fix 🥳
This was referenced Jun 17, 2022
ravicious
added a commit
that referenced
this pull request
Jun 23, 2022
#12281 fixed fetching db users for remote clusters for `tsh db ls`. #13617 applied the same fix to `tsh db ls --all` and extracted the `fetchRoleSet` function. This commit extracts it to `lib/client` so that we can reuse it in `lib/teleterm`. Other than accepting `log` as an argument, nothing was changed about that function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the logic for fetching up-to-date roles in
tsh db ls --all. The logic is now the same astsh db ls.Related: #13340 (comment)