[v10] Manually instrument cache.Cache
#13587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `trace.Tracer` to the `cache.Cache`so that all operations can be traced. Also, updates the `utils.FnCache` to link the `context.Context` passed to the loadFn to any current spans. This will allow any fetches made by the `FnCache` to be associated with the call that lead to loading. Note: There are a few methods in the `auth.Cache` interface which do not take a `context.Context`. For the time being all spans for these calls use a `context.TODO` and will be updated in the future, where the changes can be made on a per method basis.
espadolini
approved these changes
Jun 16, 2022
tigrato
approved these changes
Jun 16, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #13318 to branch/v10