Test Moderated Sessions RBAC engine for multiple session types per test case #13506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xacrimon
force-pushed
the
joel/fwd-port-access-test
branch
from
93d0974 to
0bd1334
Compare
marcoandredinis
approved these changes
Jun 17, 2022
smallinsky
approved these changes
Jun 20, 2022
xacrimon
added a commit
that referenced
this pull request
Jun 22, 2022
Merged
xacrimon
added a commit
that referenced
this pull request
Jun 22, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to test both SSH and K8S sessions for many of the test cases. Note that we don't do this for all test cases as there are semantic differences between SSH and K8S RBAC logic and some are specifically designed to catch this behaviour.