-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust tctl sso
commands to new teams_to_roles
field.
#13463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but one question. Do we need to have any additional changes to support changing/printing/anything else to the existing but deprecated teams_to_logins field since that may still be in use?
With respect to In general though? I think these 2 places may need updating: teleport/tool/tctl/common/collection.go Lines 391 to 399 in 40200e8
teleport/lib/auth/auth_with_roles.go Lines 2562 to 2579 in a61d38a
I feel like those 2 changes are out of scope of this PR... There may also be other places that need changing? I'm not sure though. |
With recent addition of
teams_to_roles
field to Github auth connectors, some adjustments are needed:tctl sso configure github
populateteams_to_roles
fieldteams_to_roles
mappingtctl sso test
aware ofteams_to_roles
mapping from diagnostic fieldThis PR supersedes code changes in #13148.