Refactor tbot #12855
Merged
Refactor tbot #12855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
force-pushed
the
strideynet/refactor-tbot
branch
from
e011bbf to
0556a5d
Compare
|
It would be nice to get this reviewed and merged some time this week, as work on |
timothyb89
approved these changes
May 31, 2022
There was a problem hiding this comment.
I think this is a big improvement! I don't see any issues but did manage to find my own bug while testing, go figure: #13034
Anyway, just a few nitpicks. Thanks for being flexible with this!
strideynet
force-pushed
the
strideynet/refactor-tbot
branch
4 times, most recently
from
dc43938 to
7ececda
Compare
capnspacehook
approved these changes
Jun 1, 2022
strideynet
force-pushed
the
strideynet/refactor-tbot
branch
from
7ececda to
db428be
Compare
|
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Jun 1, 2022
* start refactoring tbot to have a core struct * refactor tbot into lib/ * move `tbot` subpackages to `lib/tbot` * remove mutex pointer * move `tshwrap` to `lib/` from `/tool/tbot/` * move new template ssh client render test to lib/ * address pr feedback * add request changed
strideynet
added a commit
that referenced
this pull request
Jun 1, 2022
* Demonstrate usage of `golden` for tbot template generation tests. (#12898) * Refactor tbot (#12855) * start refactoring tbot to have a core struct * refactor tbot into lib/ * move `tbot` subpackages to `lib/tbot` * remove mutex pointer * move `tshwrap` to `lib/` from `/tool/tbot/` * move new template ssh client render test to lib/ * address pr feedback * add request changed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors tbot to:
lib/tbot, preserving purely CLI functionality withintool/tbotThis is part of work on #10891, as it's currently difficult for the CA rotation watcher to interact with the auth client used by the renewal mechanism.