Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set TELEPORT_ETCD_TEST=yes. #12784

Merged
merged 2 commits into from
May 20, 2022
Merged

Set TELEPORT_ETCD_TEST=yes. #12784

merged 2 commits into from
May 20, 2022

Conversation

Tener
Copy link
Contributor

@Tener Tener commented May 20, 2022

As far as I can tell, we have a bug in our current code:

	cmd.Env = append(os.Environ(), "TELEPORT_ETCD_TEST=yes")
	cmd.Env = append(os.Environ(), "TELEPORT_XAUTH_TEST=yes")

Given the above, cmd.Env will not have "TELEPORT_ETCD_TEST=yes" set.

@Tener Tener requested review from tcsc, zmb3 and Joerger May 20, 2022 14:10
zmb3
zmb3 approved these changes May 20, 2022
View reviewed changes
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

codingllama
codingllama approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, thanks.

.cloudbuild/scripts/cmd/unit-tests/main.go Show resolved Hide resolved
@Tener Tener enabled auto-merge (squash) May 20, 2022 15:01
@Tener Tener merged commit 0b2f54d into master May 20, 2022
Tener added a commit that referenced this pull request May 24, 2022
@Tener
Set TELEPORT_ETCD_TEST=yes. (#12784)
dd1a38e
@Tener Tener mentioned this pull request May 24, 2022
Merged
Tener added a commit that referenced this pull request May 24, 2022
@Tener
Set TELEPORT_ETCD_TEST=yes. (#12784)
4dc3df5
@Tener Tener mentioned this pull request May 24, 2022
Merged
@Tener Tener deleted the tener/enable-etcd-tests branch May 24, 2022 07:24
Tener added a commit that referenced this pull request May 24, 2022
@Tener
[v8] Set TELEPORT_ETCD_TEST=yes. (#12784) (#12850)
7fc1bf1
Tener added a commit that referenced this pull request May 25, 2022
@Tener
[v9] Set TELEPORT_ETCD_TEST=yes. (#12784) (#12851)
13b501c
@webvictim webvictim mentioned this pull request Jun 8, 2022
Closed
@alexatcanva alexatcanva mentioned this pull request Oct 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingllama codingllama codingllama approved these changes

@zmb3 zmb3 zmb3 approved these changes

@marcoandredinis marcoandredinis marcoandredinis approved these changes

@tcsc tcsc Awaiting requested review from tcsc

@Joerger Joerger Awaiting requested review from Joerger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tener @marcoandredinis @zmb3 @codingllama