-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce verbosity of missing kernel support warning for secure symlink #12396
Reduce verbosity of missing kernel support warning for secure symlink #12396
Conversation
6620b6e
to
26f4bbb
Compare
@timothyb89 - by re-using the same sync.Once here, the message will only be displayed once across creation and writing. I can't see any reason to display it once for creation and once for writing, but wanted to run this past you. |
26f4bbb
to
efff21f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, thanks!
efff21f
to
b749c70
Compare
Forgot to mention, we should backport this to branch/v9 |
Hmm, we could ! I'm not too sure what our process is on backporting though, do we have a bot for this ? |
I think we've got a bot in the works, but for now I'd just: git checkout branch/b9
git checkout -b user/v9/branchname
git cherry-pick 9348ef172f86dc4c5f70a8f053f02fc54fb818e5 ... and push up a PR for the result, with a base branch of |
If you add labels to your PR before you merge, e.g. |
Thanks @rosstimothy, I'll keep that in mind next time. @timothyb89 I'll raise that now :) |
Closes #11755
Follows the same solution as used elsewhere, using a
sync.Once
to ensure warnings related to the missing syscall are only displayed once. This is a bit of a hacky solution, but matches the solution already in use, and only controls a log message.