Replace title-less Details boxes with ScopedBlocks #12358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
approved these changes
May 3, 2022
ptgott
force-pushed
the
paul.gottschling/2022-05-details-titles
branch
from
9573b13 to
abc2f97
Compare
strideynet
approved these changes
May 11, 2022
ptgott
force-pushed
the
paul.gottschling/2022-05-details-titles
branch
from
abc2f97 to
6e82c82
Compare
We will be adding a linter rule that prohibits Details boxes that lack titles, letting us implement the ability to link directly to a Details box. In some places in the docs, Details boxes are used purely to adjust the visibility of Markdown based on scope. Now that we have a ScopedBlock component, we can use this instead.
ptgott
force-pushed
the
paul.gottschling/2022-05-details-titles
branch
from
6e82c82 to
b45e285
Compare
ptgott
added a commit
that referenced
this pull request
May 12, 2022
Backports #12358 We will be adding a linter rule that prohibits Details boxes that lack titles, letting us implement the ability to link directly to a Details box. In some places in the docs, Details boxes are used purely to adjust the visibility of Markdown based on scope. Now that we have a ScopedBlock component, we can use this instead.
ptgott
added a commit
that referenced
this pull request
May 12, 2022
Backports #12358 We will be adding a linter rule that prohibits Details boxes that lack titles, letting us implement the ability to link directly to a Details box. In some places in the docs, Details boxes are used purely to adjust the visibility of Markdown based on scope. Now that we have a ScopedBlock component, we can use this instead.
ptgott
added a commit
that referenced
this pull request
May 16, 2022
Backports #12358 We will be adding a linter rule that prohibits Details boxes that lack titles, letting us implement the ability to link directly to a Details box. In some places in the docs, Details boxes are used purely to adjust the visibility of Markdown based on scope. Now that we have a ScopedBlock component, we can use this instead.
ptgott
added a commit
that referenced
this pull request
May 16, 2022
Backports #12358 We will be adding a linter rule that prohibits Details boxes that lack titles, letting us implement the ability to link directly to a Details box. In some places in the docs, Details boxes are used purely to adjust the visibility of Markdown based on scope. Now that we have a ScopedBlock component, we can use this instead.
ptgott
added a commit
that referenced
this pull request
May 16, 2022
Backports #12358 We will be adding a linter rule that prohibits Details boxes that lack titles, letting us implement the ability to link directly to a Details box. In some places in the docs, Details boxes are used purely to adjust the visibility of Markdown based on scope. Now that we have a ScopedBlock component, we can use this instead.
ptgott
added a commit
that referenced
this pull request
May 16, 2022
Backports #12358 We will be adding a linter rule that prohibits Details boxes that lack titles, letting us implement the ability to link directly to a Details box. In some places in the docs, Details boxes are used purely to adjust the visibility of Markdown based on scope. Now that we have a ScopedBlock component, we can use this instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will be adding a linter rule that prohibits Details boxes that lack
titles, letting us implement the ability to link directly to a Details
box. In some places in the docs, Details boxes are used purely to
adjust the visibility of Markdown based on scope. Now that we have a
ScopedBlock component, we can use this instead.