Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates terraform docs for provider #12314

Merged
merged 3 commits into from
May 3, 2022
Merged

Updates terraform docs for provider #12314

merged 3 commits into from
May 3, 2022

Conversation

tcsc
Copy link
Contributor

@tcsc tcsc commented Apr 29, 2022

Updates the Terraform getting started guide to reflect the use of a
custome provider registry:

  • Removes the now-superfluous installation step
  • Updates examples to reflect actual location of terraform provider

@tcsc
Updates terraform docs for provider
355b860 
Updates the Terraform getting started guide to reflect the use of a
custome provider registry:

 * Removes the now-superfluous installation step
 * Updates examples to reflect actual location of terraform provider
codingllama
codingllama approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not deeply familiar with our Terraform usage/setup, but seems reasonable to me.

@codingllama
Copy link
Contributor

codingllama commented Apr 29, 2022 •
edited
Loading

Btw, the bot picked a bunch of reviewers for this. Is that something we could fix?

@tcsc tcsc merged commit e228fe5 into master May 3, 2022
@tcsc tcsc deleted the tcsc/terraform-docs branch May 3, 2022 00:18
tcsc added a commit that referenced this pull request May 12, 2022
@tcsc
Updates terraform docs for provider (#12314)
ea1ddde 
Updates the Terraform getting started guide to reflect the use of a
custome provider registry:

 * Removes the now-superfluous installation step
 * Updates examples to reflect actual location of terraform provider
tcsc added a commit that referenced this pull request May 17, 2022
@tcsc
Updates terraform docs for provider (#12314) (#12595)
679db8e 
Updates the Terraform getting started guide to reflect the use of a
custome provider registry:

 * Removes the now-superfluous installation step
 * Updates examples to reflect actual location of terraform provider
@webvictim webvictim mentioned this pull request Jun 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingllama codingllama codingllama approved these changes

@zmb3 zmb3 zmb3 approved these changes

@r0mant r0mant r0mant approved these changes

@atburke atburke Awaiting requested review from atburke

@ptgott ptgott Awaiting requested review from ptgott

@xinding33 xinding33 Awaiting requested review from xinding33

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcsc @codingllama @r0mant @zmb3