[branch/v9] Prevent relative expiry from emitting more events than can be processed (#12002) #12247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
fspmarshall,
LKozlowski and
smallinsky
rosstimothy
force-pushed
the
backport/branch/v9/pr-12002
branch
from
1edbe0f to
4c9fb58
Compare
…ed (#12002) * Prevent relative expiry from emitting more events than can be processed This alters relative expiry in four ways: 1) Relative expiry is no longer exclusively run by the auth cache 2) Relative expiry no longer emits delete events 3) There is now a limit to the number of nodes removed per interval 4) Relative expiry now runs more frequently We can remove the need to emit any fake delete events during relative expiry by not running it exclusively in the auth cache. All caches will now run relative expiry themselves, even the components that don't watch for nodes - this is effectively a noop for them. To prevent the individual caches from getting too far out of sync, the expiry interval is set to a much smaller value and we limit the number of nodes being deleted per interval. (cherry picked from commit b8394b3)
rosstimothy
force-pushed
the
backport/branch/v9/pr-12002
branch
from
4c9fb58 to
fe06101
Compare
smallinsky
approved these changes
Apr 27, 2022
fspmarshall
approved these changes
Apr 28, 2022
|
friendly ping @LKozlowski |
LKozlowski
approved these changes
May 2, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mastertobranch/v9:Questions ?
Please refer to the Backport tool documentation