Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify user creation in database access guides #12136

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Simplify user creation in database access guides #12136

merged 1 commit into from
Apr 26, 2022

Conversation

r0mant
Copy link
Collaborator

@r0mant r0mant commented Apr 21, 2022

A few tweaks:

  • Take advantage of the feature implemented in Allow setting additional traits in tctl users add command #12102 and simplify "create Teleport user" instructions in database access guides. Users no longer need to export/edit the user.
  • Make sure that all guides use the "create user" include page. Some older ones weren't using it.
  • Update obsolete tctl users add CLI reference.

@github-actions github-actions bot requested review from ptgott, xinding33 and zmb3 April 21, 2022 02:17
@r0mant r0mant enabled auto-merge (squash) April 21, 2022 18:20
@ptgott ptgott disabled auto-merge April 22, 2022 20:22
ptgott
ptgott approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor suggestions. Disabled auto-merge in case you'd like to apply them.

docs/pages/includes/database-access/create-user.mdx Outdated Show resolved Hide resolved
docs/pages/includes/database-access/create-user.mdx Outdated Show resolved Hide resolved
docs/pages/database-access/guides/mysql-self-hosted.mdx Outdated Show resolved Hide resolved
docs/pages/database-access/guides/postgres-self-hosted.mdx Outdated Show resolved Hide resolved
@r0mant r0mant enabled auto-merge (squash) April 26, 2022 14:46
@r0mant r0mant merged commit e2091c6 into master Apr 26, 2022
@r0mant r0mant deleted the roman/docs/user branch April 26, 2022 14:51
r0mant added a commit that referenced this pull request Apr 26, 2022
@r0mant
Simplify user creation in database access guides (#12136)
42eaf4e
@r0mant r0mant mentioned this pull request Apr 26, 2022
Merged
r0mant added a commit that referenced this pull request Apr 26, 2022
@r0mant
Simplify user creation in database access guides (#12136) (#12235)
ee00eb0
@webvictim webvictim mentioned this pull request Jun 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptgott ptgott ptgott approved these changes

@zmb3 zmb3 zmb3 approved these changes

@xinding33 xinding33 Awaiting requested review from xinding33

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r0mant @zmb3 @ptgott