Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update help message for add token command and allow token removal from the rm command. #12118

Merged
merged 4 commits into from
Apr 20, 2022
Merged

Update help message for add token command and allow token removal from the rm command. #12118

merged 4 commits into from
Apr 20, 2022

Conversation

hatched
Copy link
Contributor

@hatched hatched commented Apr 20, 2022

Updated the help message for the add token command and allowed token removal from the rm command.

Fixes: #11819
Fixes: #11798

@github-actions github-actions bot added the tctl tctl - Teleport admin tool label Apr 20, 2022
codingllama
codingllama approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, but let's set a more descriptive PR title.

@hatched hatched changed the title Hatched/small tweaks Update help message for add token command and allow token removal from the rm command. Apr 20, 2022
greedy52
greedy52 approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@greedy52 greedy52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

though in general seems our command help is very inconsistent. some flags end sentences with . but some have no period. And i think i saw some put e.g. in brackets but others don't.

@hatched
Copy link
Contributor Author

hatched commented Apr 20, 2022

Thanks for the reviews!

@greedy52 I agree, we will need to set aside time to work on the CLI help and output consistency sometime in the future.

@hatched hatched enabled auto-merge (squash) April 20, 2022 17:09
@hatched hatched merged commit ee78893 into master Apr 20, 2022
@hatched hatched deleted the hatched/small-tweaks branch April 20, 2022 19:49
hatched added a commit that referenced this pull request May 5, 2022
@hatched
Update help message for add token command and allow token removal f…
d7b0fab 
…rom the `rm` command. (#12118)

* Update tokens add messaging to outline that it can be a list of tokens.

* Allow deleting tokens with rm.
hatched added a commit that referenced this pull request May 5, 2022
@hatched
Update help message for add token command and allow token removal f…
c02cf2a 
…rom the `rm` command. (#12118)

* Update tokens add messaging to outline that it can be a list of tokens.

* Allow deleting tokens with rm.
hatched added a commit that referenced this pull request May 5, 2022
@hatched
Update help message for add token command and allow token removal f…
2c2fc0b 
…rom the `rm` command. (#12118) (#12440)

* Update tokens add messaging to outline that it can be a list of tokens.

* Allow deleting tokens with rm.
hatched added a commit that referenced this pull request May 5, 2022
@hatched
Update help message for add token command and allow token removal f…
5dadc57 
…rom the `rm` command. (#12118) (#12439)

* Update tokens add messaging to outline that it can be a list of tokens.

* Allow deleting tokens with rm.
@webvictim webvictim mentioned this pull request Jun 8, 2022
Closed
@alexatcanva alexatcanva mentioned this pull request Oct 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingllama codingllama codingllama approved these changes

@greedy52 greedy52 greedy52 approved these changes

Assignees
No one assigned
Labels
tctl tctl - Teleport admin tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TCTL token removal tctl tokens add: improve help message
3 participants
@hatched @greedy52 @codingllama