Make windows terminal keep up with real time #11905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyb89
reviewed
Apr 13, 2022
…oser to real-time. The speed increase makes it so that VT sequences are captured properly by windows.
Joerger
force-pushed
the
joerger/ansi-escape-windows-fix
branch
from
eed7521 to
b34207b
Compare
rosstimothy
reviewed
May 23, 2022
Joerger
force-pushed
the
joerger/ansi-escape-windows-fix
branch
from
57fed3b to
c9c6d94
Compare
rosstimothy
reviewed
May 24, 2022
…ional/teleport into joerger/ansi-escape-windows-fix
rosstimothy
reviewed
May 24, 2022
Joerger
force-pushed
the
joerger/ansi-escape-windows-fix
branch
from
996ca3d to
0e1e87d
Compare
Joerger
force-pushed
the
joerger/ansi-escape-windows-fix
branch
from
0e1e87d to
ed714d8
Compare
rosstimothy
approved these changes
May 24, 2022
|
@timothyb89 Can you do a quick re-review when you get a chance? |
timothyb89
approved these changes
Jun 3, 2022
Joerger
added
backport/branch/v9
backport-required
and removed
backport/branch/v9
labels
Joerger
added a commit
that referenced
this pull request
Jun 6, 2022
Use a buffered channel pipe to increase the speed of windows stdin closer to real-time. The speed increase makes it so that VT sequences are captured properly by windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the speed of the windows terminal stdin. This was done by replacing the subscription based sequence event channel with a very efficient buffered channel pipe which pipes directly into stdin. Anything less efficient (io.Pipe, unbuffered channel) will not transmit VT sequence keystrokes quickly enough for Windows to group them as VT sequence.
Note: Tested with a 4gb memory Windows virtual box.
Fixes #11340