-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RDS Redshift dynamic resources registration logic #11868
Merged
smallinsky
merged 1 commit into
master
from
smallinsky/fix_db_app_dynamic_resource_matcher
May 5, 2022
Merged
Fix RDS Redshift dynamic resources registration logic #11868
smallinsky
merged 1 commit into
master
from
smallinsky/fix_db_app_dynamic_resource_matcher
May 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallinsky
force-pushed
the
smallinsky/fix_db_app_dynamic_resource_matcher
branch
2 times, most recently
from
April 11, 2022 08:25
170e2c8
to
7db474c
Compare
In the original ticket, the sample config is
Is that
Or
I feel it's the later one? |
smallinsky
force-pushed
the
smallinsky/fix_db_app_dynamic_resource_matcher
branch
from
April 22, 2022 11:57
2ceb5bd
to
fd29b8b
Compare
smallinsky
changed the title
Fix dynamic app db resource matcher
Fix RDS Redshift dynamic resources registration logic
Apr 22, 2022
github-actions
bot
added
the
database-access
Database access related issues and PRs
label
Apr 22, 2022
greedy52
approved these changes
Apr 22, 2022
jakule
approved these changes
Apr 22, 2022
smallinsky
force-pushed
the
smallinsky/fix_db_app_dynamic_resource_matcher
branch
from
April 25, 2022 11:23
b430fab
to
8a4cda2
Compare
rosstimothy
approved these changes
May 4, 2022
smallinsky
force-pushed
the
smallinsky/fix_db_app_dynamic_resource_matcher
branch
from
May 5, 2022 08:55
1668ab3
to
92ee0a1
Compare
@smallinsky See the table below for backport results.
|
smallinsky
added a commit
that referenced
this pull request
May 5, 2022
smallinsky
added a commit
that referenced
this pull request
May 5, 2022
smallinsky
added a commit
that referenced
this pull request
May 6, 2022
smallinsky
added a commit
that referenced
this pull request
May 6, 2022
r0mant
pushed a commit
that referenced
this pull request
May 6, 2022
smallinsky
added a commit
that referenced
this pull request
May 6, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The RDS Redshift resource types registered dynamically by
tctl create -f db-resource.yaml
are evaluated agains DB Service Resource Matchers.Only DB Cloud Originated resources should skip ResourceMatchers evaluation logic.
Issue: #11285