Bump rdp-rs #11768
Merged
Bump rdp-rs #11768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
approved these changes
Apr 6, 2022
| @@ -213,7 +213,7 @@ fn connect_rdp_inner( | |||
| )?; | |||
| // Generate a random 8-digit PIN for our smartcard. | |||
| let mut rng = rand_chacha::ChaCha20Rng::from_entropy(); | |||
| let pin = format!("{:08}", rng.gen_range(0..99999999)); | |||
| let pin = format!("{:08}", rng.gen_range(0i32..=99999999i32)); | |||
There was a problem hiding this comment.
What's up with the explicit type?
There was a problem hiding this comment.
Rust 1.59 (which I'm running locally but we don't use for builds yet) complains about it.
timothyb89
approved these changes
Apr 6, 2022
I had made some changes to rdp-rs to expose new flags for tweaking some performance characteristics, but never got around to pulling in the update here. Fix this now so as not to block upcoming work the team is doing on rdp-rs.
zmb3
added a commit
that referenced
this pull request
May 27, 2022
I had made some changes to rdp-rs to expose new flags for tweaking some performance characteristics, but never got around to pulling in the update here. Fix this now so as not to block upcoming work the team is doing on rdp-rs. Use RustCrypto/RSA instead of OpenSSL RustCrypto is preferred, as it's a pure-Rust implementation, which simplifies cross compilation for us and prevents us from needing to pull in all of OpenSSL. We originally thought that OpenSSL would be required here as RustCrypto didn't appear to support RSA decryption without padding, but that turned out to be false. Remove OpenSSL dependency from the rust RDP client
zmb3
added a commit
that referenced
this pull request
May 27, 2022
* Bump rdp-rs (#11768) I had made some changes to rdp-rs to expose new flags for tweaking some performance characteristics, but never got around to pulling in the update here. Fix this now so as not to block upcoming work the team is doing on rdp-rs. * Use RustCrypto/RSA instead of OpenSSL RustCrypto is preferred, as it's a pure-Rust implementation, which simplifies cross compilation for us and prevents us from needing to pull in all of OpenSSL. We originally thought that OpenSSL would be required here as RustCrypto didn't appear to support RSA decryption without padding, but that turned out to be false. * Remove OpenSSL dependency from the rust RDP client Co-authored-by: Zac Bergquist <[email protected]> Co-authored-by: Zac Bergquist <[email protected]>
LKozlowski
pushed a commit
that referenced
this pull request
Jun 7, 2022
I had made some changes to rdp-rs to expose new flags for tweaking some performance characteristics, but never got around to pulling in the update here.
LKozlowski
pushed a commit
that referenced
this pull request
Jun 7, 2022
I had made some changes to rdp-rs to expose new flags for tweaking some performance characteristics, but never got around to pulling in the update here.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had made some changes to rdp-rs to expose new flags for tweaking
some performance characteristics, but never got around to pulling
in the update here.
Fix this now so as not to block upcoming work the team is doing
on rdp-rs.