Add manual websocket pingloop #11765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xacrimon
force-pushed
the
joel/readd-pingloop
branch
from
3e13906 to
9311a83
Compare
russjones
reviewed
Apr 6, 2022
codingllama
reviewed
Apr 6, 2022
xacrimon
force-pushed
the
joel/readd-pingloop
branch
from
c566e34 to
371fd38
Compare
codingllama
approved these changes
Apr 11, 2022
|
@greedy52 friendly ping :) |
greedy52
reviewed
Apr 12, 2022
@greedy52 Sadly not, proxies like Cloudflare care about the activity state of the WS connection on a protocol level. |
greedy52
approved these changes
Apr 12, 2022
xacrimon
force-pushed
the
joel/readd-pingloop
branch
from
6655f65 to
ec97859
Compare
xacrimon
added a commit
that referenced
this pull request
Apr 13, 2022
Merged
xacrimon
added a commit
that referenced
this pull request
Apr 20, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR readds the pre-v9 websocket pingloop. The documentation for the new websocket library used in v9 caused some confusion on my end about interactions with proxies. We need this to send more frequent ping messages manually to avoid websocket termination by proxy.
Fixes #11763