Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reuse vchan::Client to add the general header and break messages into chunks #11714

Merged
merged 14 commits into from
Apr 13, 2022
Merged

reuse vchan::Client to add the general header and break messages into chunks #11714

merged 14 commits into from
Apr 13, 2022

Conversation

ibeckermayer
Copy link
Contributor

vchan::Client

An add_header_and_chunkify method has been added to handle adding the Channel PDU Header that's required for every message sent over a virtual channel, and breaking the payload up into chunks of size <= CHANNEL_CHUNK_LEGNTH.

rdpdr.rs and cliprdr.rs

encode_message has been replaced with Client.add_headers_and_chunkify, which adds the channel specific headers and then calls vchan::Client.add_header_and_chunkify to finalize the message.

@ibeckermayer ibeckermayer requested a review from zmb3 April 4, 2022 21:06
@github-actions github-actions bot requested review from timothyb89 and xacrimon April 4, 2022 21:07
zmb3
zmb3 reviewed Apr 4, 2022
View reviewed changes
lib/srv/desktop/rdp/rdpclient/src/vchan.rs Outdated Show resolved Hide resolved
lib/srv/desktop/rdp/rdpclient/src/vchan.rs Outdated Show resolved Hide resolved
lib/srv/desktop/rdp/rdpclient/src/cliprdr.rs Outdated Show resolved Hide resolved
@ibeckermayer ibeckermayer enabled auto-merge (squash) April 4, 2022 23:09
@ibeckermayer ibeckermayer merged commit c4deb1c into master Apr 13, 2022
@ibeckermayer ibeckermayer deleted the isaiah/reuse-vchan-write branch April 13, 2022 21:22
ibeckermayer pushed a commit that referenced this pull request Jun 16, 2022
reuse vchan::Client to add the general header and break messages in…
1de5f9e 
…to chunks (#11714)
@ibeckermayer ibeckermayer mentioned this pull request Jun 16, 2022
Merged
ibeckermayer pushed a commit that referenced this pull request Jun 21, 2022
reuse vchan::Client to add the general header and break messages in…
495de0f 
…to chunks (#11714)
@ibeckermayer ibeckermayer mentioned this pull request Jun 21, 2022
Merged
ibeckermayer pushed a commit that referenced this pull request Jun 29, 2022
[v9] Backport #11616, #11714, and #12499 (#13707)
975f88c 
* Abstract-out chunked read logic (#11616)

* reuse `vchan::Client` to add the general header and break messages into chunks (#11714)

* `CGOError` --> `CGOErrCode` (#12499)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xacrimon xacrimon xacrimon approved these changes

@zmb3 zmb3 zmb3 approved these changes

@timothyb89 timothyb89 timothyb89 approved these changes

Assignees
No one assigned
Labels
desktop-access rdp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ibeckermayer @timothyb89 @zmb3 @xacrimon