-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace session upload grace period with session tracker #11551
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joerger
force-pushed
the
joerger/grace-period-fixes
branch
from
March 29, 2022 23:50
22e1735
to
7fa8705
Compare
xacrimon
approved these changes
Apr 1, 2022
Joerger
force-pushed
the
joerger/grace-period-fixes
branch
from
April 1, 2022 22:31
f3c370f
to
a61117e
Compare
zmb3
reviewed
Apr 3, 2022
xacrimon
reviewed
Apr 3, 2022
Sorry, meant to post a suggestion diff comment but tripped up in the VSCode online UI and accidentally pushed a commit with the change, please have a look at the commit and see if it looks reasonable. |
…king to accurately determine whether an upload has been abandoned; Update session tracker expiration to be 1 hour, and dynamically extend it while the session is active.
Joerger
force-pushed
the
joerger/grace-period-fixes
branch
from
April 6, 2022 17:02
c9346af
to
c61e2a4
Compare
zmb3
approved these changes
Apr 8, 2022
Joerger
added a commit
that referenced
this pull request
Apr 8, 2022
* Replace Upload completer grace period logic with session tracker checking to accurately determine whether an upload has been abandoned * Update session tracker expiration to be 1 hour, and dynamically extend it while the session is active.
This was referenced Apr 9, 2022
Merged
Joerger
added a commit
that referenced
this pull request
Apr 11, 2022
* Replace session upload grace period with session tracker (#11551) * Replace Upload completer grace period logic with session tracker checking to accurately determine whether an upload has been abandoned
This was referenced Apr 18, 2022
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
session_tracker
expiration logic.SessionTracker.Expiry()
, is reached, it will be removed from the backend.SessionTracker.Spec.Expires
is set, it will be a strict expiration which won't be affected by the following dynamics.SessionTrackerUpdateExpiry
grpc request to enable dynamic updates of the session expiration based on session state.PENDING
state, the session tracker will expire after 1 hour.TERMINATED
, then the expiration will be set totime.Now()
to mark it for immediate removal.