Clean up remoteSites with no active tunnels #11435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not closing a remoteSite causes a continuous retry to init the cache on the remote auth client. Not only does this cause log spam but is a waste of resources. We now stop tracking and close a remoteSite when its heartBeat fails and no active tunnels are established for the site. Fixes #11197
rosstimothy
force-pushed
the
tross/remote_site_clean_up
branch
from
edb04d7 to
648d6b7
Compare
github-actions
bot
added
the
database-access
lxea
approved these changes
Mar 29, 2022
timothyb89
approved these changes
Mar 29, 2022
rosstimothy
added a commit
that referenced
this pull request
Apr 4, 2022
Not closing a remoteSite causes a continuous retry to init the cache on the remote auth client. Not only does this cause log spam but is a waste of resources. We now stop tracking and close a remoteSite when its heartBeat fails and no active tunnels are established for the site. Fixes #11197 (cherry picked from commit 3d5928f) # Conflicts: # lib/reversetunnel/fake.go # lib/srv/db/access_test.go
rosstimothy
added a commit
that referenced
this pull request
Apr 4, 2022
Not closing a remoteSite causes a continuous retry to init the cache on the remote auth client. Not only does this cause log spam but is a waste of resources. We now stop tracking and close a remoteSite when its heartBeat fails and no active tunnels are established for the site. Fixes #11197 (cherry picked from commit 3d5928f) # Conflicts: # lib/reversetunnel/fake.go # lib/srv/db/access_test.go
rosstimothy
added a commit
that referenced
this pull request
Apr 4, 2022
Not closing a remoteSite causes a continuous retry to init the cache on the remote auth client. Not only does this cause log spam but is a waste of resources. We now stop tracking and close a remoteSite when its heartBeat fails and no active tunnels are established for the site. Fixes #11197 (cherry picked from commit 3d5928f) # Conflicts: # lib/reversetunnel/fake.go # lib/srv/db/access_test.go
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
rosstimothy
added a commit
that referenced
this pull request
Apr 5, 2022
Not closing a remoteSite causes a continuous retry to init the cache on the remote auth client. Not only does this cause log spam but is a waste of resources. We now stop tracking and close a remoteSite when its heartBeat fails and no active tunnels are established for the site. Fixes #11197 (cherry picked from commit 3d5928f)
rosstimothy
added a commit
that referenced
this pull request
Apr 5, 2022
Not closing a remoteSite causes a continuous retry to init the cache on the remote auth client. Not only does this cause log spam but is a waste of resources. We now stop tracking and close a remoteSite when its heartBeat fails and no active tunnels are established for the site. Fixes #11197 (cherry picked from commit 3d5928f)
rosstimothy
added a commit
that referenced
this pull request
Apr 5, 2022
Not closing a remoteSite causes a continuous retry to init the cache on the remote auth client. Not only does this cause log spam but is a waste of resources. We now stop tracking and close a remoteSite when its heartBeat fails and no active tunnels are established for the site. Fixes #11197 (cherry picked from commit 3d5928f)
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not closing a remoteSite causes a continuous retry to init the cache
on the remote auth client. Not only does this cause log spam but is
a waste of resources.
We now stop tracking and close a remoteSite when its heartBeat fails
and no active tunnels are established for the site.
Fixes #11197