Default to synchronous FULL for the sqlite backend
#11387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
changed the title
FULL for the sqlite backend
Helps with robustness, and clusters so big that the auth backend performance will be affected by this change are also so big that they should've probably been using etcd/dynamo already anyway.
espadolini
force-pushed
the
espadolini/sensible-sqlite-fsync
branch
from
a076fb1 to
92594db
Compare
Tener
approved these changes
Mar 31, 2022
r0mant
approved these changes
Mar 31, 2022
espadolini
added a commit
that referenced
this pull request
Apr 1, 2022
espadolini
added a commit
that referenced
this pull request
Apr 1, 2022
espadolini
added a commit
that referenced
this pull request
Apr 1, 2022
This was referenced Apr 1, 2022
espadolini
added a commit
that referenced
this pull request
Apr 1, 2022
* Always use in-memory caches (#11386) * Always use in-memory caches This also cleans up now-useless fields and constants related to on-disk caches. * Remove the cache tombstone mechanism As we're never reopening the same cache backend twice, this is no longer useful. * Warn if a cache directory exists on disk We can't remove it automatically because we might be in the middle of an upgrade with a old version of Teleport still running. * Default to synchronous FULL for sqlite (#11387)
espadolini
added a commit
that referenced
this pull request
Apr 1, 2022
* Always use in-memory caches (#11386) * Always use in-memory caches This also cleans up now-useless fields and constants related to on-disk caches. * Remove the cache tombstone mechanism As we're never reopening the same cache backend twice, this is no longer useful. * Warn if a cache directory exists on disk We can't remove it automatically because we might be in the middle of an upgrade with a old version of Teleport still running. * Default to synchronous FULL for sqlite (#11387)
espadolini
added a commit
that referenced
this pull request
Apr 1, 2022
* Always use in-memory caches (#11386) * Always use in-memory caches This also cleans up now-useless fields and constants related to on-disk caches. * Remove the cache tombstone mechanism As we're never reopening the same cache backend twice, this is no longer useful. * Warn if a cache directory exists on disk We can't remove it automatically because we might be in the middle of an upgrade with a old version of Teleport still running. * Default to synchronous FULL for sqlite (#11387)
Closed
Closed
This was referenced Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default
synchronouspragma toFULLrather thanOFF. This helps prevent database corruption in case of system crashes or power loss.The performance impact should only be noticeable in clusters so big that they should've been switched to etcd/dynamodb already, and the option is configurable in the
auth_service.storagesection of the auth configuration file, so it can be turned back toOFFthere if needed.Closes #11119.