-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change client dialOpts append order #11322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In regards to adding metrics, an interceptor may not necessarily be the best place to do so. Depending on what you are trying to capture a stats.Handler might be a better choice. See the work being done by @NajiObeid for proxy peering as an example: https://github.com/gravitational/teleport/pull/10440/files#diff-8d990324c72abe37d2e979e4f1d582d0de4429065256667df8ef597cc30fef55
* change order of dialOpts to respect config provided opts
* change order of dialOpts to respect config provided opts
Any
dialOpts
that are provided in the config but collide with what we set indialGRPC()
will be overridden. This change allows any config options to take precedent.Example client snippet:
Prior to this change, you wouldn't be able to setup a client and get grpc metrics with it (or any additional client interceptors).
The end goal is to get grpc client metrics on the proxy.