Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v7] Backport #11085 #11233

Merged
merged 4 commits into from
Mar 18, 2022
Merged

[v7] Backport #11085 #11233

merged 4 commits into from
Mar 18, 2022

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Mar 17, 2022

Backports #11085

@zmb3 @ptgott
docs: clarify /healthz and /readyz (#11085)
67ce5a2 
- Rename the page, since it's about diagnostics rather than metrics
  alone
- Change major section headings to H2s so they apper in the table of
  contents
- Move information about heartbeats and recovery to an H3 so it's
  more visible

Updates #10799

Co-authored-by: Paul Gottschling <[email protected]>
codingllama
codingllama approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zmb3, could we make your backport tool set the title/description of the PRs according to the original? A git log full of "[vN] Backport #XXXX" isn't the best.

@zmb3
Copy link
Collaborator Author

zmb3 commented Mar 18, 2022 •
edited
Loading

Good idea @codingllama - done.

Also note that the git log still has full fidelity, as the title of the PR is not the same as the commit message that is backported.

@zmb3 zmb3 enabled auto-merge (squash) March 18, 2022 14:21
@zmb3 zmb3 merged commit 83dbf72 into branch/v7 Mar 18, 2022
@zmb3 zmb3 deleted the v7-backport-11085 branch March 18, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptgott ptgott ptgott approved these changes

@codingllama codingllama codingllama approved these changes

@russjones russjones russjones approved these changes

@r0mant r0mant Awaiting requested review from r0mant

@xinding33 xinding33 Awaiting requested review from xinding33

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zmb3 @russjones @codingllama @ptgott