[v9] backport #10706 (concurrent sqlite access) #11190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use BEGIN IMMEDIATE to start transactions This makes it so all transactions grab a write lock rather than a read lock that can be upgraded in case of a write; in case of multiple writers (which, in our case, can only happen during a restart as the new process reopens the same sqlite database) this will prevent two transactions from attempting to upgrade their lock, which would cause a SQLITE_BUSY error in one of them. In regular operation this shouldn't cause a performance hit, as we're using a single connection to the sqlite database (guarded by locks in the go side) anyway. * Escape path in sqlite connection URL This makes it so that the sqlite backend supports paths with ? in them. * Close process storage on TeleportProcess shutdown This aligns the behavior of Shutdown with that of Close. * Allow specifying the journal mode in sqlite This will let sqlite backend users specify WAL mode in their config file, and will allow us to specify alternate journal modes for our on-disk caches in the future. This also removes sqlite memory mode, as it's not used anywhere because of its poor query performance compared to our in-memory backend, and cleans up a bit of old cruft, and runs process storage in FULL sync mode - it's very seldom written to and holds important data.
github-actions
bot
requested review from
fspmarshall,
rosstimothy,
xacrimon and
zmb3
rosstimothy
approved these changes
Mar 17, 2022
xacrimon
approved these changes
Mar 17, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10706.