-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new ListResources
in the webapi layer for pagination and filtering
#11019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add
6d6f2b0
to
bfd192a
Compare
bfd192a
to
584feaa
Compare
|
@kimlisa in a hypothetical future in which we can do filtering in the backend itself that extra flag would force us to still figure out if something else could've been available - wouldn't it be simpler to only show the getting started UI element if the filter textbox is empty? |
This reverts commit 584feaa.
i think you're right @espadolini, it's also weird that we are ignoring the filter field too (in the UI b/c it will get replaced with the empty state), reverted |
Supports pagination and filtering for the web UI Part of RFD 55
Supports pagination and filtering for the web UI Part of RFD 55
part of RFD 55
Description
In addition proccess query params sent in with request
Before Merge