Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates tsh ls for nodes, apps, dbs, and kubes to accept new filter flags #10980

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Updates tsh ls for nodes, apps, dbs, and kubes to accept new filter flags #10980

merged 4 commits into from
Mar 9, 2022

Conversation

kimlisa
Copy link
Contributor

@kimlisa kimlisa commented Mar 8, 2022 •
edited
Loading

part of RFD 55

Description

  • Adds new flags --search (keywords), --query (predicate), and labels.
  • Add a search keyword parser that takes in different delimiters (comma is used for tsh, space is used for web UI)

Backwards Compat Test

  • tsh vCurrent -> auth v8 (using the new flags here with an older auth silently does not apply the filters)

@github-actions github-actions bot requested review from alex-kovoy and rudream March 8, 2022 22:57
@github-actions github-actions bot added kubernetes-access tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Mar 8, 2022
@kimlisa kimlisa removed request for alex-kovoy and rudream March 8, 2022 22:58
@kimlisa kimlisa force-pushed the lisa/tsh-new-flags branch from 396b772 to 95ebd78 Compare March 9, 2022 05:47
@kimlisa kimlisa enabled auto-merge (squash) March 9, 2022 23:49
@zmb3
Copy link
Collaborator

zmb3 commented Mar 9, 2022

Bot

zmb3
zmb3 approved these changes Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot

@kimlisa kimlisa merged commit 350ea5b into master Mar 9, 2022
@kimlisa kimlisa deleted the lisa/tsh-new-flags branch March 9, 2022 23:56
kimlisa added a commit that referenced this pull request Mar 9, 2022
@kimlisa
Updates tsh ls for node/app/db/kube to accept new filter flags (#10980
bf8095d 
)

* Also adds a search keyword parser that takes in different
  delimiters (comma is used for tsh, space is used for web UI)

part of RFD 55
@kimlisa kimlisa mentioned this pull request Mar 10, 2022
Merged
1 task
kimlisa added a commit that referenced this pull request Mar 14, 2022
@kimlisa
Updates tsh ls for node/app/db/kube to accept new filter flags (#10980
12b451e 
)

* Also adds a search keyword parser that takes in different
  delimiters (comma is used for tsh, space is used for web UI)

part of RFD 55
kimlisa added a commit that referenced this pull request Mar 18, 2022
@kimlisa
Updates tsh ls for node/app/db/kube to accept new filter flags (#10980
7499530 
) (#11016)

* Also adds a search keyword parser that takes in different
  delimiters (comma is used for tsh, space is used for web UI)

part of RFD 55
@rosstimothy rosstimothy mentioned this pull request Mar 29, 2022
Closed
@webvictim webvictim mentioned this pull request Apr 19, 2022
Closed
@webvictim webvictim mentioned this pull request Jun 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosstimothy rosstimothy rosstimothy approved these changes

@zmb3 zmb3 zmb3 approved these changes

@espadolini espadolini espadolini approved these changes

Assignees
No one assigned
Labels
backport-required kubernetes-access tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kimlisa @zmb3 @espadolini @rosstimothy