[v8] Do not block apt publishing if there is a more current pre-release #10806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not publish pre-releases to apt repos, but we do publish them to github. That means we need to filter them out when considering if an apt release should be published. We don't want v8.3.3 to be blocked by v9.0.0-dev.1, only by v9.0.0. Honestly, this is a bit of a mess, but it only needs to hold out a bit longer until #10746 lands. Contributes to #10800 (cherry picked from commit 08bc483)
r0mant
approved these changes
Mar 3, 2022
russjones
approved these changes
Mar 3, 2022
zmb3
approved these changes
Mar 3, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8 backport of #10804
Summary
We do not publish pre-releases to apt repos, but we do publish them to github. That means we need to filter pre-releases out of the github release list when considering if an apt release should be published. We don't want v8.3.3 publishing to be blocked by v9.0.0-dev.1, only by v9.0.0.
Contributes to #10800
This is as far back as the port needs to go, as v7 apt packages will never be published anyhow.
Testing Done
None, beyond what was done in the original #10804