Add KindWindowsDesktops to ListResources
#10769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimlisa
requested review from
zmb3,
espadolini and
rosstimothy
and removed request for
alex-kovoy and
gzdunek
kimlisa
force-pushed
the
lisa/windows-desktops
branch
from
fbb3d62 to
f3ffbcb
Compare
zmb3
requested changes
Mar 3, 2022
espadolini
approved these changes
Mar 3, 2022
|
@espadolini it was b/c |
rosstimothy
approved these changes
Mar 4, 2022
zmb3
approved these changes
Mar 5, 2022
kimlisa
force-pushed
the
lisa/windows-desktops
branch
from
a92f5f3 to
5ebcc82
Compare
kimlisa
added a commit
that referenced
this pull request
Mar 7, 2022
* Also add windows desktops sorter and its type converters * Use forked vulcand/predicate library: allows traversing by embedded fields Part of RFD 55
kimlisa
added a commit
that referenced
this pull request
Mar 7, 2022
* Also add windows desktops sorter and its type converters * Use forked vulcand/predicate library: allows traversing by embedded fields Part of RFD 55
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of RFD 55
Description
To add support for type windows desktops to our generic
ListResources, it needed it's own implementationListWindowsDesktopsin its own service layer (all other resources thus far belongs in the presence layer). This function is not made available to the client, they would need to useListResourceswith typeKindWindowsDesktop.In addition adds support for sorting.
Required PR