Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop playback error handling #10765

Merged
merged 11 commits into from
Mar 3, 2022

Conversation

ibeckermayer
Copy link
Contributor

See description in the corresponding webapps PR: gravitational/webapps#638

@ibeckermayer ibeckermayer added test-plan-problem Issues which have been surfaced by running the manual release test plan backport-required labels Mar 2, 2022
@ibeckermayer ibeckermayer requested a review from zmb3 March 2, 2022 23:15
@github-actions github-actions bot requested review from espadolini and nklaassen March 2, 2022 23:16
Copy link
Contributor

@nklaassen nklaassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

lib/web/desktop/playback.go Outdated Show resolved Hide resolved
@russjones
Copy link
Contributor

@ibeckermayer Looks like this is approved, can we merge?

@espadolini espadolini removed their request for review March 3, 2022 08:09
@ibeckermayer ibeckermayer enabled auto-merge (squash) March 3, 2022 14:45
@ibeckermayer ibeckermayer merged commit 896dbbb into master Mar 3, 2022
@ibeckermayer ibeckermayer deleted the isaiah/desktop-playback-error-handling branch March 3, 2022 20:07
ibeckermayer pushed a commit that referenced this pull request Mar 4, 2022
ibeckermayer pushed a commit that referenced this pull request Mar 7, 2022
@webvictim webvictim mentioned this pull request Apr 19, 2022
@webvictim webvictim mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-required desktop-access test-plan-problem Issues which have been surfaced by running the manual release test plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants