Fix artifacts path for build-darwin-amd64-pkg-tsh drone pipeline

[r0mant]

The build-darwin-amd64-pkg-tsh build pipeline was accidentally using artifacts path from build-darwin-amd64-pkg which worked only coincidentally (and unreliably) when two pipelines were running in parallel and oftentimes would lead to the tsh pipeline failing with:

Can't find /tmp/build-darwin-amd64-pkg/go/artifacts/teleport-v7.3.16-darwin-amd64-bin.tar.gz
Downloading from https://get.gravitational.com/ is disabled when a path is provided with -s

[wadells]

Does this need to be added to dronegen?

[webvictim]

@wadells Yes, if we're still using dronegen then all these miscellaneous pipelines should be implemented there. This would have ultimately prevented this typo.

[wadells]

@wadells Yes, if we're still using dronegen then all these miscellaneous pipelines should be implemented there. This would have ultimately prevented this typo.

What I was getting at is: this pipeline is already managed in dronegen:

teleport/dronegen/mac_pkg.go

Lines 108 to 110 in 123fc2c

	func darwinTshPkgPipeline() pipeline {
	return darwinPkgPipeline("build-darwin-amd64-pkg-tsh", "pkg-tsh", []string{"build/tsh*.pkg"})
	}

These changes will be reverted the next time it is run:

walt@work:~/git/teleport$ git status                    
On branch master
Your branch is up to date with 'grav/master'.

nothing to commit, working tree clean
walt@work:~/git/teleport$ make dronegen
go run ./dronegen
walt@work:~/git/teleport$ git diff
diff --git a/.drone.yml b/.drone.yml
index a9fc85875..ed1535308 100644
--- a/.drone.yml
+++ b/.drone.yml
@@ -3113,9 +3113,9 @@ steps:
     ARCH: amd64
     BUILDBOX_PASSWORD:
       from_secret: BUILDBOX_PASSWORD
-    ENT_TARBALL_PATH: /tmp/build-darwin-amd64-pkg-tsh/go/artifacts
+    ENT_TARBALL_PATH: /tmp/build-darwin-amd64-pkg/go/artifacts
     OS: darwin
-    OSS_TARBALL_PATH: /tmp/build-darwin-amd64-pkg-tsh/go/artifacts
+    OSS_TARBALL_PATH: /tmp/build-darwin-amd64-pkg/go/artifacts
     WORKSPACE_DIR: /tmp/build-darwin-amd64-pkg-tsh
 - name: Copy Mac pkg artifacts
   commands:
@@ -5040,6 +5040,6 @@ volumes:
       name: drone-s3-debrepo-pvc
 ---
 kind: signature
-hmac: 2fa9a32bf1f8b0fe5ef6abb7b0cdd30df5cd8813ca2bdbc3fdbd9b1d7296f459
+hmac: 0c5316489efc1bfa9acfd87bed0e2807ec4f2b8e123649c168c9d675e3c8a4cc

[r0mant]

@wadells Ah good catch. I'll send a follow up PR to update dronegen today.

[r0mant]

Looks like it's only on master and v9, correct? Older branches don't seem to have dronegen.

[wadells]

Looks like it's only on master and v9, correct? Older branches don't seem to have dronegen.

@russjones removed dronegen from v8 in fadcdaf.

I believe it is still present in v7 and v6.2. v5 and before predate dronegen.

[webvictim]

What I was getting at is: this pipeline is already managed in dronegen:

That makes a lot more sense :)

@russjones removed dronegen from v8 in fadcdaf.

Arguably we should have fixed those affected pipelines in dronegen rather than removing it entirely. The bulk of Drone's YAML is still for publishing artifacts rather than running tests.