Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] Update desktop access docs for 9.0 (#10406) #10545

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Feb 23, 2022

Update desktop access docs for 9.0

  • Remove admonition about being in preview
  • Add audit events listing
  • Break reference.mdx up into separate pages

Backports #10406

* Update desktop access docs for 9.0

- Remove admonition about being in preview
- Add audit events listing
- Break reference.mdx up into separate pages

* Update tile icons

* Address review suggestions

* Another review pass
@zmb3 zmb3 changed the title Update desktop access docs for 9.0 (#10406) [v9] Update desktop access docs for 9.0 (#10406) Feb 23, 2022
desktop: true

# Specify whether clipboard sharing should be allowed with the
# remote desktop (requires a supported browser). Defaults to true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires a supported browser

Are the supported browsers mentioned anywhere?

windows_desktop_logins: ["{{internal.windows_logins}}"]
```

## Clipboard Access
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in this section would be a good place to add an admonition specifying which browsers support clipboard sharing.

```

In order to disable desktop session recording for a user, *all* of the user's
roles must disable it. In other words, the presence of a single role which
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think the "In other words..." sentence is superflous.


### Direct mode

In *direct* mode, Windows Desktop Services registers directly with the Teleport
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In *direct* mode, Windows Desktop Services registers directly with the Teleport
In *direct* mode, Windows Desktop Service registers directly with the Teleport

@zmb3
Copy link
Collaborator Author

zmb3 commented Feb 23, 2022

Thanks for the review, @r0mant.

Since this is a backport, I'll open up a separate PR to master with your suggested improvements.

@zmb3 zmb3 added the backport label Feb 24, 2022
@zmb3 zmb3 enabled auto-merge (squash) February 25, 2022 13:41
@zmb3 zmb3 merged commit bd7de89 into branch/v9 Feb 25, 2022
@zmb3 zmb3 deleted the zmb3/backport-10406 branch February 25, 2022 13:46
@webvictim webvictim mentioned this pull request Apr 19, 2022
@webvictim webvictim mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants