Fix utmp accounting on system with bad glibc default #10460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xacrimon
force-pushed
the
joel/uacc-rhel-fix
branch
from
dcd5e75 to
3e0faf9
Compare
hatched
approved these changes
Feb 22, 2022
smallinsky
reviewed
Feb 23, 2022
smallinsky
approved these changes
Feb 23, 2022
xacrimon
added a commit
that referenced
this pull request
Feb 25, 2022
xacrimon
added a commit
that referenced
this pull request
Feb 25, 2022
xacrimon
added a commit
that referenced
this pull request
Feb 25, 2022
xacrimon
added a commit
that referenced
this pull request
Mar 3, 2022
xacrimon
added a commit
that referenced
this pull request
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems, mainly RHEL, the
_*_PATHmacros used to resolve the utmp UNIX user accounting database are sometimes wrong. Did some digging, still not sure why, added further details as a comment. This seems to work everywhere and I've had users test this on affected systems.This PR also adds additional diagnostics if
realpathdecides to fail in such a way that glibc exposes extra debugging info as a non-posix extension.Needs backport to v8.
Fixes #8360