Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set role examples to v4 and add detail warnings #10345

Merged
merged 12 commits into from
Feb 14, 2022
Merged

Set role examples to v4 and add detail warnings #10345

merged 12 commits into from
Feb 14, 2022

Conversation

xacrimon
Copy link
Contributor

No description provided.

@xacrimon xacrimon requested a review from ptgott February 14, 2022 17:31
@xacrimon xacrimon self-assigned this Feb 14, 2022
ptgott
ptgott reviewed Feb 14, 2022
View reviewed changes
docs/pages/access-controls/guides/moderated-sessions.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/reference.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/reference.mdx Outdated Show resolved Hide resolved
@xacrimon xacrimon requested a review from ptgott February 14, 2022 18:04
ptgott
ptgott approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor suggestions but approved so you're not blocked.

docs/pages/access-controls/reference.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/reference.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/reference.mdx Outdated Show resolved Hide resolved
zmb3
zmb3 reviewed Feb 14, 2022
View reviewed changes
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like we should mention that v4 roles will be automatically migrated to v5 upon upgrading to teleport 8.3.0

@xacrimon
Copy link
Contributor Author

Feels like we should mention that v4 roles will be automatically migrated to v5 upon upgrading to teleport 8.3.0

@zmb3 Added a sentence about it but note that they aren't automatically migrated due to the RBAC poisoning mechanics for SSH.

@xacrimon xacrimon requested a review from zmb3 February 14, 2022 19:08
@benarent
Copy link
Contributor

Feels like we should mention that v4 roles will be automatically migrated to v5 upon upgrading to teleport 8.3.0

I'm running a 8.0.0 and my roles are still on v3 when did we introduce v4?

@xacrimon
Copy link
Contributor Author

@benarent It's complicated, v4 roles came around during v6 or so I believe. That said, a lot of internal systems still rely on V3 behaviour which is why it's a default for many internal roles and other things.

@xacrimon xacrimon requested a review from zmb3 February 14, 2022 20:38
@zmb3 zmb3 merged commit b390fb5 into branch/v8 Feb 14, 2022
@zmb3 zmb3 deleted the joel/v8/doc-mod-session-ver branch February 14, 2022 21:36
@zmb3
Copy link
Collaborator

zmb3 commented Feb 14, 2022

Merged.

@xacrimon don't forget to make any corresponding updates to master before we cut branch/v9 later this week.

xacrimon added a commit that referenced this pull request Feb 16, 2022
@xacrimon
Revert "Set role examples to v4 and add detail warnings (#10345)"
092c749 
This reverts commit b390fb5.
zmb3 pushed a commit that referenced this pull request Feb 16, 2022
@xacrimon @zmb3
Revert "Set role examples to v4 and add detail warnings (#10345)"
34bd99f 
This reverts commit b390fb5.
zmb3 pushed a commit that referenced this pull request Feb 16, 2022
@xacrimon
[v8] Revert Moderated Sessions docs (#10399)
632e4b4 
* Revert "Set role examples to v4 and add detail warnings (#10345)"

This reverts commit b390fb5.

* Revert "Add documentation for moderated sessions (#9425) (#10302)"

This reverts commit e8ed183.
@webvictim webvictim mentioned this pull request Mar 4, 2022
Closed
@alexatcanva alexatcanva mentioned this pull request Oct 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptgott ptgott ptgott approved these changes

@zmb3 zmb3 zmb3 approved these changes

@r0mant r0mant Awaiting requested review from r0mant

@xinding33 xinding33 Awaiting requested review from xinding33

Assignees

@xacrimon xacrimon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xacrimon @benarent @zmb3 @ptgott