Tag build images with teleport8 instead of go version #10211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
reviewed
Feb 8, 2022
| @@ -4721,6 +4721,7 @@ name: build-buildboxes | |||
| environment: | |||
| GID: "1000" | |||
| RUNTIME: go1.17.3 | |||
| BUILDBOX_VERSION: teleport8 | |||
There was a problem hiding this comment.
Is the idea here that once this is backported we will then update master to something other than teleport8?
There was a problem hiding this comment.
This PR is targeted at branch/v8, and I've added branch/v8 to the trigger selection on the Drone pipeline, so that Drone will build the images on merges to branch/v8 as well as master. master should be untouched.
There was a problem hiding this comment.
We can forward-port it to master with teleport9 if that makes sense, but I was mainly focussed on unjamming v8
zmb3
approved these changes
Feb 8, 2022
r0mant
approved these changes
Feb 8, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, the
buildboximages used for CI have always just been tagged with the version of Go they support. In the past this has been discrete enough to stay inside individual release boundaries.Recently, though, the version of Go used by Teleport 8 and Teleport 9 has remained constant, while other requirements of the the build environment have changed, leading to the unfortunate situation where publishing a
buildboximage that works for Teleport 9 breaks the Teleport 8 build.This patch de-couples the version of the buildbox from the version of Go installed on it, and produces a new
teleport8-tagged buildbox image for Teleport 8 builds to use.