Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing DatabasesReady event #10152

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Add missing DatabasesReady event #10152

merged 2 commits into from
Feb 11, 2022

Conversation

jakule
Copy link
Contributor

@jakule jakule commented Feb 4, 2022

Currently DB proxy is not sending DatabasesReady. In a consequence during CA rotation periodic sync rotation sync never happens

process.WaitForEvent(process.ExitContext(), TeleportReadyEvent, eventC)
and DB proxy fails to re-connect to proxy after Host CA is rotated.

@jakule jakule added the bug label Feb 4, 2022
@github-actions github-actions bot requested a review from quinqu February 4, 2022 16:05
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakule Before we merge this, could you add some test coverage?

Copy link
Contributor

@smallinsky smallinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you extend the testRotateSuccess integration test. It should require only setting proxy.Databases.Enable == true in a proper place ?

@jakule jakule enabled auto-merge (squash) February 10, 2022 23:17

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jakule jakule force-pushed the jakule/db-proxy-ready branch from a9f0e22 to 4de94fa Compare February 11, 2022 02:17
@jakule jakule merged commit ed62fa1 into master Feb 11, 2022
@jakule jakule deleted the jakule/db-proxy-ready branch February 11, 2022 02:37
jakule added a commit that referenced this pull request Feb 11, 2022
* Add missing DatabasesReady

* Expect TeleportReadyEvent to be emitted when DB proxy run in tests.
jakule added a commit that referenced this pull request Feb 11, 2022
* Add missing DatabasesReady

* Expect TeleportReadyEvent to be emitted when DB proxy run in tests.
jakule added a commit that referenced this pull request Feb 17, 2022
* Add missing DatabasesReady

* Expect TeleportReadyEvent to be emitted when DB proxy runs in tests.
@webvictim webvictim mentioned this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants