-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing DatabasesReady event #10152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakule Before we merge this, could you add some test coverage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you extend the testRotateSuccess
integration test. It should require only setting proxy.Databases.Enable == true
in a proper place ?
03f4249
to
e660a99
Compare
a9f0e22
to
4de94fa
Compare
* Add missing DatabasesReady * Expect TeleportReadyEvent to be emitted when DB proxy run in tests.
* Add missing DatabasesReady * Expect TeleportReadyEvent to be emitted when DB proxy run in tests.
Currently DB proxy is not sending
DatabasesReady
. In a consequence during CA rotation periodic sync rotation sync never happensteleport/lib/service/connect.go
Line 471 in 6cb1371