Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-default service account for pre-hook Jobs #48477

Closed
bradyz7 opened this issue Nov 5, 2024 · 2 comments · Fixed by #48530
Closed

Use non-default service account for pre-hook Jobs #48477

bradyz7 opened this issue Nov 5, 2024 · 2 comments · Fixed by #48530
Labels

Comments

@bradyz7
Copy link

bradyz7 commented Nov 5, 2024

What would you like Teleport to do?
The pods created by the auth pre-deploy job and proxy pre-deploy job use the default service account. Instead, the pods should respect the service account set in serviceAccount.name

What problem does this solve?
This is similar to #21421 for the test jobs in teleport-cluster using the default service account

If a workaround exists, please include it.
No, we don't have a workaround at the moment

@zmb3
Copy link
Collaborator

zmb3 commented Nov 5, 2024

Duplicate of #21384?

@zmb3 zmb3 added the helm label Nov 5, 2024
@bradyz7
Copy link
Author

bradyz7 commented Nov 6, 2024

Duplicate of #21384?

Not exactly, it seems #21384 is to have the option for the proxy service account to have a different name besides {{- coalesce .Values.serviceAccount.name .Release.Name -}}-proxy, while the ask here is to be able to set an alternative service account for the auth and proxy pre-deploy jobs at all.

github-merge-queue bot pushed a commit that referenced this issue Nov 6, 2024
* helm: Add serviceAccountName to pre-deploy jobs

Fixes #48477

* Create separate serviceAccount resources for running pre-deploy hooks

* Clarification
github-actions bot pushed a commit that referenced this issue Nov 6, 2024
github-actions bot pushed a commit that referenced this issue Nov 6, 2024
github-actions bot pushed a commit that referenced this issue Nov 6, 2024
github-actions bot pushed a commit that referenced this issue Nov 6, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2024
* helm: Add serviceAccountName to pre-deploy jobs

Fixes #48477

* Create separate serviceAccount resources for running pre-deploy hooks

* Clarification
github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2024
* helm: Add serviceAccountName to pre-deploy jobs

Fixes #48477

* Create separate serviceAccount resources for running pre-deploy hooks

* Clarification
github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2024
* helm: Add serviceAccountName to pre-deploy jobs

Fixes #48477

* Create separate serviceAccount resources for running pre-deploy hooks

* Clarification
github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2024
* helm: Add serviceAccountName to pre-deploy jobs

Fixes #48477

* Create separate serviceAccount resources for running pre-deploy hooks

* Clarification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants