fix unit test, address feedback

gravitational · Mar 26, 2024 · dfa690a · dfa690a
1 parent 3a4a09f
commit dfa690a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lib/auth/auth_login_test.go b/lib/auth/auth_login_test.go
@@ -531,9 +531,9 @@ func TestCreateAuthenticateChallenge_mfaVerification(t *testing.T) {
 			t.Parallel()
 
 			resp, err := test.userClient.IsMFARequired(ctx, test.req)
-			require.NoError(t, err, "CreateAuthenticateChallenge")
+			require.NoError(t, err, "IsMFARequired")
 
-			assert.Equal(t, test.wantMFARequired, resp.Required, "resp.MFARequired mismatch")
+			assert.Equal(t, test.wantMFARequired, resp.Required, "resp.Required mismatch")
 		})
 	}
 }

diff --git a/lib/srv/authhandlers_test.go b/lib/srv/authhandlers_test.go
@@ -280,7 +280,7 @@ func TestRBACJoinMFA(t *testing.T) {
 	// create auth handler and dummy node
 	config := &AuthHandlerConfig{
 		Server:      server,
-		Emitter:     &eventstest.MockRecorderEmitter{},
+		Emitter:     &eventstest.MockEmitter{},
 		AccessPoint: accessPoint,
 	}
 	ah, err := NewAuthHandlers(config)
@@ -295,7 +295,7 @@ func TestRBACJoinMFA(t *testing.T) {
 
 	mfaAuthPref, err := types.NewAuthPreference(types.AuthPreferenceSpecV2{
 		SecondFactor:   constants.SecondFactorOTP,
-		RequireMFAType: types.RequireMFAType_HARDWARE_KEY_TOUCH,
+		RequireMFAType: types.RequireMFAType_SESSION,
 	})
 	require.NoError(t, err)
 
@@ -317,7 +317,7 @@ func TestRBACJoinMFA(t *testing.T) {
 		},
 	})
 	require.NoError(t, err)
-	_, err = server.auth.CreateRole(ctx, joinMFARole)
+	err = server.auth.CreateRole(ctx, joinMFARole)
 	require.NoError(t, err)
 
 	joinRole, err := types.NewRole("join", types.RoleSpecV6{
@@ -328,7 +328,7 @@ func TestRBACJoinMFA(t *testing.T) {
 		},
 	})
 	require.NoError(t, err)
-	_, err = server.auth.CreateRole(ctx, joinRole)
+	err = server.auth.CreateRole(ctx, joinRole)
 	require.NoError(t, err)
 
 	tests := []struct {